More ruby documentation; prototype general model.rb add methods #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
reviewed
Sep 19, 2024
|
@shorowit Can you fill in remaining TODOs for |
…o ruby-docs # Conflicts: # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.xml # ReportUtilityBills/measure.xml
Done. |
… methods into HPXMLDefaults and added documentation.
…o ruby-docs # Conflicts: # HPXMLtoOpenStudio/measure.xml # ReportUtilityBills/measure.xml
shorowit
changed the title
shorowit
changed the title
…riendly names. Added code to prevent duplicate sensors.
shorowit
changed the title
… HPXMLDefaults_get_default_foo with Defaults.get_foo. Renames hpxml_defaults.rb to defaults.rb.
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Addresses #1759.
Also starts prototyping generic
Model.add_footo model.rb to consolidate code that creates OSM objects. It makes the objects easier to use, and it allows us to introduce additional logic that applies to every object of the same type (like using EMS-friendly variable names or avoiding the need for a developer to remember to use.to_son an object name to get a string).Checklist
Not all may apply:
EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run